Issue 2742007: Remove old named property query API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2742007: Remove old named property query API. (Closed)

Created:
10 years, 6 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Remove old named property query API. Committed: http://code.google.com/p/v8/source/detail?r=4867

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mads' commetns #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -82 lines)			Patch
M	include/v8.h	View	1	5 chunks	+6 lines, -49 lines	0 comments	Download
M	src/api.cc	View		3 chunks	+14 lines, -15 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+5 lines, -12 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-debug.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/cctest/test-decls.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

antonm

Mads, may you have a look? As discussed on IM, I'm going to submit it ...

10 years, 6 months ago (2010-06-11 12:22:56 UTC) #1

Mads Ager (chromium)

10 years, 6 months ago (2010-06-11 12:33:12 UTC) #2

LGTM

http://codereview.chromium.org/2742007/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/2742007/diff/1/2#newcode2089
include/v8.h:2089: * \param query The callback to invoke to check if property is
present,
if property -> if a property

http://codereview.chromium.org/2742007/diff/1/2#newcode2090
include/v8.h:2090: *   and if present, its attributes.
its attributes -> get its attributes.

Expand Messages | Collapse Messages