Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2742005: Adjust xpdual/moz/total_byte_b. (Closed)

Created:
10 years, 6 months ago by chase
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Adjust xpdual/moz/total_byte_b. r49390 caused an increase in total_byte_b. This is an error because there's no listener for cookies in the page cycler yet the data is sent anyway. This should be fixed in a later change, possibly 2 weeks out. BUG=46275 TEST=xpdual moz is green TBR=nsylvain@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf_expectations/perf_expectations.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
chase
10 years, 6 months ago (2010-06-10 18:30:18 UTC) #1
Nicolas Sylvain
10 years, 6 months ago (2010-06-10 18:44:57 UTC) #2
lg

On Thu, Jun 10, 2010 at 11:30 AM, <chase@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Adjust xpdual/moz/total_byte_b.
>
> r49390 caused an increase in total_byte_b.
> This is an error because there's no listener for cookies
> in the page cycler yet the data is sent anyway.
> This should be fixed in a later change, possibly 2 weeks out.
>
> BUG=46275
> TEST=xpdual moz is green
> TBR=nsylvain@chromium.org
>
> Please review this at http://codereview.chromium.org/2742005/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
>  M tools/perf_expectations/perf_expectations.json
>
>
> Index: tools/perf_expectations/perf_expectations.json
> diff --git a/tools/perf_expectations/perf_expectations.json
> b/tools/perf_expectations/perf_expectations.json
> index
>
a4f5e67add08316b07b9c09d4583f3d414998bc3..dcd472b3e076ba67b4857f222f92ae80ae28c58c
> 100644
> --- a/tools/perf_expectations/perf_expectations.json
> +++ b/tools/perf_expectations/perf_expectations.json
> @@ -41,7 +41,7 @@
>  "xp-release-dual-core/intl2/times/t": {"delta": 0, "var": 30},
>  "xp-release-dual-core/morejs/times/t": {"delta": -40, "var": 20},
>  "xp-release-dual-core/moz/times/t": {"delta": 20, "var": 20},
> - "xp-release-dual-core/moz/total_byte_b/IO_b": {"delta": -15, "var": 100},
> + "xp-release-dual-core/moz/total_byte_b/IO_b": {"delta": 750, "var": 100},
>  "xp-release-dual-core/moz/total_byte_r/IO_r": {"delta": 60, "var": 55},
>  "xp-release-dual-core/moz/total_op_b/IO_op_b": {"delta": -1100, "var":
> 740},
>  "xp-release-dual-core/moz/total_op_r/IO_op_r": {"delta": 535, "var": 590},
>
>
>

Powered by Google App Engine
This is Rietveld 408576698