Adds support for showing accelerators in bookmark menus.

Adds support for showing accelerators in bookmark menus.

BUG=45734
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49335

[Jay Civelli, 2010-06-09 20:36:39]

LGTM

http://codereview.chromium.org/2742003/diff/1/6
File views/controls/menu/menu_item_view.cc (right):

http://codereview.chromium.org/2742003/diff/1/6#newcode473
views/controls/menu/menu_item_view.cc:473: if
(!GetDelegate()->GetAccelerator(GetCommand(), &accelerator))
Would it make sense to have an GetAcceleratorText private method used this
method and GeAccceletorWidth, and to bail early here if the text is empty?

[sky, 2010-06-09 21:16:29]

Good idea. New patch uploaded.

  -Scott

On Wed, Jun 9, 2010 at 1:36 PM,  <jcivelli@chromium.org> wrote:
> LGTM
>
>
> http://codereview.chromium.org/2742003/diff/1/6
> File views/controls/menu/menu_item_view.cc (right):
>
> http://codereview.chromium.org/2742003/diff/1/6#newcode473
> views/controls/menu/menu_item_view.cc:473: if
> (!GetDelegate()->GetAccelerator(GetCommand(), &accelerator))
> Would it make sense to have an GetAcceleratorText private method used
> this method and GeAccceletorWidth, and to bail early here if the text is
> empty?
>
> http://codereview.chromium.org/2742003/show
>

[Jay Civelli, 2010-06-09 21:27:32]

LGTM!