Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2742003: Adds support for showing accelerators in bookmark menus. (Closed)

Created:
10 years, 6 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
Jay Civelli
CC:
chromium-reviews
Visibility:
Public.

Description

Adds support for showing accelerators in bookmark menus. BUG=45734 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49335

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added GetAcceleratorText #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -25 lines) Patch
M views/accelerator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M views/accelerator.cc View 2 chunks +10 lines, -1 line 0 comments Download
M views/controls/menu/menu_config.h View 2 chunks +24 lines, -18 lines 0 comments Download
M views/controls/menu/menu_delegate.h View 1 chunk +6 lines, -0 lines 0 comments Download
M views/controls/menu/menu_item_view.h View 1 2 chunks +10 lines, -0 lines 0 comments Download
M views/controls/menu/menu_item_view.cc View 1 5 chunks +40 lines, -2 lines 0 comments Download
M views/controls/menu/menu_item_view_gtk.cc View 2 chunks +4 lines, -1 line 0 comments Download
M views/controls/menu/menu_item_view_win.cc View 2 chunks +4 lines, -1 line 0 comments Download
M views/controls/menu/submenu_view.h View 2 chunks +7 lines, -0 lines 0 comments Download
M views/controls/menu/submenu_view.cc View 4 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
10 years, 6 months ago (2010-06-09 20:17:23 UTC) #1
Jay Civelli
LGTM http://codereview.chromium.org/2742003/diff/1/6 File views/controls/menu/menu_item_view.cc (right): http://codereview.chromium.org/2742003/diff/1/6#newcode473 views/controls/menu/menu_item_view.cc:473: if (!GetDelegate()->GetAccelerator(GetCommand(), &accelerator)) Would it make sense to ...
10 years, 6 months ago (2010-06-09 20:36:39 UTC) #2
sky
Good idea. New patch uploaded. -Scott On Wed, Jun 9, 2010 at 1:36 PM, <jcivelli@chromium.org> ...
10 years, 6 months ago (2010-06-09 21:16:29 UTC) #3
Jay Civelli
10 years, 6 months ago (2010-06-09 21:27:32 UTC) #4
LGTM!

Powered by Google App Engine
This is Rietveld 408576698