Fix unicode bidi mirroring characters are not correctly mirrored in textfield

views/controls/textfield/native_textfield_win.h

-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_WIN_H_
 #define VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_WIN_H_
 
 #include <atlbase.h>
 #include <atlapp.h>
 #include <atlcrack.h>
 #include <atlctrls.h>
@@ skipping 99 matching lines @@
     ScopedFreeze(NativeTextfieldWin* edit, ITextDocument* text_object_model);
     ~ScopedFreeze();
 
    private:
     NativeTextfieldWin* const edit_;
     ITextDocument* const text_object_model_;
 
     DISALLOW_COPY_AND_ASSIGN(ScopedFreeze);
   };
 
+  // This object suspends placing any operations on the edit's undo stack until
+  // the object is destroyed.  If we don't do this, some of the operations we
+  // perform behind the user's back will be undoable by the user, which feels
+  // bizarre and confusing.
+  class ScopedSuspendUndo {
+   public:
+    explicit ScopedSuspendUndo(ITextDocument* text_object_model);
+    ~ScopedSuspendUndo();
+
+   private:
+    ITextDocument* const text_object_model_;
+
+    DISALLOW_COPY_AND_ASSIGN(ScopedSuspendUndo);
+  };
+
   // message handlers
   void OnChar(TCHAR key, UINT repeat_count, UINT flags);
   void OnContextMenu(HWND window, const POINT& point);
   void OnCopy();
   void OnCut();
   LRESULT OnImeChar(UINT message, WPARAM wparam, LPARAM lparam);
   LRESULT OnImeStartComposition(UINT message, WPARAM wparam, LPARAM lparam);
   LRESULT OnImeComposition(UINT message, WPARAM wparam, LPARAM lparam);
   LRESULT OnImeEndComposition(UINT message, WPARAM wparam, LPARAM lparam);
   void OnKeyDown(TCHAR key, UINT repeat_count, UINT flags);
@@ skipping 11 matching lines @@
   void OnSysChar(TCHAR ch, UINT repeat_count, UINT flags);
 
   // Helper function for OnChar() and OnKeyDown() that handles keystrokes that
   // could change the text in the edit.
   void HandleKeystroke(UINT message, TCHAR key, UINT repeat_count, UINT flags);
 
   // Every piece of code that can change the edit should call these functions
   // before and after the change.  These functions determine if anything
   // meaningful changed, and do any necessary updating and notification.
   void OnBeforePossibleChange();
-  void OnAfterPossibleChange();
+
+  // When a user types a BIDI mirroring character (e.g. left parenthesis
+  // U+0028, which should be rendered as '(' in LTR context unless  surrounded
+  // by RTL characters in both sides, and it should be rendered as ')' in RTL
+  // context unless surrounded by LTR characters in both sides.), the textfield
+  // does not properly mirror the character when necessary. However, if we
+  // explicitly set the text in the edit to the entire current string, then
+  // the BIDI mirroring characters will be mirrored properly. When
+  // |should_redraw_text| is true, we explicitly set the text in the edit to
+  // the entire current string any time the text changes.
+  void OnAfterPossibleChange(bool should_redraw_text);
 
   // Given an X coordinate in client coordinates, returns that coordinate
   // clipped to be within the horizontal bounds of the visible text.
   //
   // This is used in our mouse handlers to work around quirky behaviors of the
   // underlying CRichEditCtrl like not supporting triple-click when the user
   // doesn't click on the text itself.
   //
   // |is_triple_click| should be true iff this is the third click of a triple
   // click.  Sadly, we need to clip slightly differently in this case.
@@ skipping 53 matching lines @@
   NativeViewHost* container_view_;
 
   COLORREF bg_color_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeTextfieldWin);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_WIN_H_