Issue 2741004: Makes it so child views of menuitemview can be traversed with the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2741004: Makes it so child views of menuitemview can be traversed with the (Closed)

Created:
10 years, 6 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews

Visibility:
Public.

Description

Makes it so child views of menuitemview can be traversed with the keyboard. Because I don't want the menu to actually get focus I'm using SetHotTracked when traversing and AcceleratorPressed from enter/return. BUG=45734 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49270

Patch Set 1 #

Patch Set 2 : Tweaks #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+250 lines, -56 lines)			Patch
M	views/controls/button/custom_button.h	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	views/controls/button/custom_button.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	views/controls/button/text_button.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	views/controls/menu/menu_config.h	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	views/controls/menu/menu_config_gtk.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	views/controls/menu/menu_config_win.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	views/controls/menu/menu_controller.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	views/controls/menu/menu_controller.cc	View		7 chunks	+121 lines, -4 lines	2 comments	Download
M	views/controls/menu/menu_item_view.h	View		8 chunks	+24 lines, -13 lines	0 comments	Download
M	views/controls/menu/menu_item_view.cc	View		6 chunks	+55 lines, -24 lines	0 comments	Download
M	views/controls/menu/menu_item_view_gtk.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	views/controls/menu/menu_item_view_win.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	views/controls/menu/menu_scroll_view_container.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/controls/menu/menu_scroll_view_container.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	views/controls/menu/submenu_view.h	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jay Civelli

10 years, 6 months ago (2010-06-09 16:03:47 UTC) #2

LGTM

http://codereview.chromium.org/2741004/diff/2001/3007
File views/controls/menu/menu_controller.cc (right):

http://codereview.chromium.org/2741004/diff/2001/3007#newcode79
views/controls/menu/menu_controller.cc:79: forward);
Nit: you could use true instead of forward.

http://codereview.chromium.org/2741004/diff/2001/3007#newcode87
views/controls/menu/menu_controller.cc:87: forward);
Nit: you could use false instead of forward.

Expand Messages | Collapse Messages