Add string16 support for LowerCaseEqualsASCII, StartsWith, and EndsWith....

Add string16 support for LowerCaseEqualsASCII, StartsWith, and EndsWith.

R=mpcomplete
BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29209

[Matt Perry, 2009-10-15 23:06:16]

lgtm

http://codereview.chromium.org/274067/diff/1/3
File base/string_util.cc (right):

http://codereview.chromium.org/274067/diff/1/3#newcode754
Line 754: #if !defined(WCHAR_T_IS_UTF16)
This confused me for a minute. Can you add a comment explaining that the wstring
definition is used when this define is set?

[darin (slow to review), 2009-10-15 23:13:15]

http://codereview.chromium.org/274067/diff/1/3
File base/string_util.cc (right):

http://codereview.chromium.org/274067/diff/1/3#newcode754
Line 754: #if !defined(WCHAR_T_IS_UTF16)
On 2009/10/15 23:06:16, Matt Perry wrote:
> This confused me for a minute. Can you add a comment explaining that the
wstring
> definition is used when this define is set? 

This #if pattern appears throughout this file.  It would be a bit verbose to
decorate them all, but it wouldn't serve the purpose unless I did.

How about if i repeated this:

#if !defined(WCHAR_T_IS_UTF16)  // string16 != wstring

[Matt Perry, 2009-10-15 23:18:47]

http://codereview.chromium.org/274067/diff/1/3
File base/string_util.cc (right):

http://codereview.chromium.org/274067/diff/1/3#newcode754
Line 754: #if !defined(WCHAR_T_IS_UTF16)
On 2009/10/15 23:13:15, darin wrote:
> On 2009/10/15 23:06:16, Matt Perry wrote:
> > This confused me for a minute. Can you add a comment explaining that the
> wstring
> > definition is used when this define is set? 
> 
> This #if pattern appears throughout this file.  It would be a bit verbose to
> decorate them all, but it wouldn't serve the purpose unless I did.
> 
> How about if i repeated this:
> 
> #if !defined(WCHAR_T_IS_UTF16)  // string16 != wstring

I didn't realize it was a common pattern. In that case, I don't think any
comment is necessary.