Add %s to the command in the Gnome url handlers....

Add %s to the command in the Gnome url handlers.

BUG=23793
TEST=Run xdg-open http://foo.com on Hardy/Gnome. The browser should open foo.com.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29103

[Lei Zhang, 2009-10-14 19:01:35]

let's try this again...

[Evan Stade, 2009-10-14 19:04:36]

the reason I abandoned my change which did essentially the same thing as this is
because I had not sufficiently tested it. How much have you tested this?

http://codereview.chromium.org/274055/diff/1/3
File third_party/xdg-utils/scripts/xdg-settings.in (right):

http://codereview.chromium.org/274055/diff/1/3#newcode324
Line 324: gconftool-2 --type string --set
/desktop/gnome/applications/browser/exec "$binary"
why no %U here?

[Lei Zhang, 2009-10-14 19:42:38]

On 2009/10/14 19:04:36, Evan Stade wrote:
> the reason I abandoned my change which did essentially the same thing as this
is
> because I had not sufficiently tested it. How much have you tested this?

I have Hardy/Jaunty/Karmic virtual machines with Gnome and KDE.

http://codereview.chromium.org/274055/diff/1/3
File third_party/xdg-utils/scripts/xdg-settings.in (right):

http://codereview.chromium.org/274055/diff/1/3#newcode324
Line 324: gconftool-2 --type string --set
/desktop/gnome/applications/browser/exec "$binary"
On 2009/10/14 19:04:37, Evan Stade wrote:
> why no %U here?

Because it's %s on Gnome. I'll change kde to use %U too. See
http://kb.mozillazine.org/Setting_Your_Default_Browser

[Evan Stade, 2009-10-14 19:50:41]

http://codereview.chromium.org/274055/diff/1/3
File third_party/xdg-utils/scripts/xdg-settings.in (right):

http://codereview.chromium.org/274055/diff/1/3#newcode324
Line 324: gconftool-2 --type string --set
/desktop/gnome/applications/browser/exec "$binary"
On 2009/10/14 19:42:38, Lei Zhang wrote:
> On 2009/10/14 19:04:37, Evan Stade wrote:
> > why no %U here?
> 
> Because it's %s on Gnome. I'll change kde to use %U too. See
> http://kb.mozillazine.org/Setting_Your_Default_Browser

well, you didn't put %s either

[Lei Zhang, 2009-10-14 20:24:20]

http://codereview.chromium.org/274055/diff/1/3
File third_party/xdg-utils/scripts/xdg-settings.in (right):

http://codereview.chromium.org/274055/diff/1/3#newcode324
Line 324: gconftool-2 --type string --set
/desktop/gnome/applications/browser/exec "$binary"
On 2009/10/14 19:50:41, Evan Stade wrote:
> On 2009/10/14 19:42:38, Lei Zhang wrote:
> > On 2009/10/14 19:04:37, Evan Stade wrote:
> > > why no %U here?
> > 
> > Because it's %s on Gnome. I'll change kde to use %U too. See
> > http://kb.mozillazine.org/Setting_Your_Default_Browser
> 
> well, you didn't put %s either

It doesn't do that either if you set a browser as the default in the UI.
Gnome-open only looks at the url-handlers, it seems.

[Evan Stade, 2009-10-14 20:25:48]

ok lg

[Lei Zhang, 2009-10-14 22:14:21]

I looked into this a bit further. It looks as though on KDE4, you don't need %U.
Putting a %U in systemsetting's default browser override actually breaks things.

If the default browser has no override, then we use the default text/html app.
In this case, google-chrome.desktop already has %U in the Exec= line.

Also WRT to the default text/html application - we get this from xdg-mime, but
xdg-mime is pretty broken on KDE 4, so there's a chance it might not work right.
See: http://bugs.freedesktop.org/show_bug.cgi?id=19392

[Mike Mammarella, 2009-10-15 02:13:47]

On 2009/10/14 22:14:21, Lei Zhang wrote:
> Also WRT to the default text/html application - we get this from xdg-mime, but
> xdg-mime is pretty broken on KDE 4, so there's a chance it might not work
right.
> See: http://bugs.freedesktop.org/show_bug.cgi?id=19392

There is a bug (18106) to include a copy of xdg-mime that fixes that bug, but
it's not yet fully fixed. The latest version still has a section that isn't
implemented for KDE4.

This change LGTM.

http://codereview.chromium.org/274055/diff/1/3
File third_party/xdg-utils/scripts/xdg-settings.in (right):

http://codereview.chromium.org/274055/diff/1/3#newcode324
Line 324: gconftool-2 --type string --set
/desktop/gnome/applications/browser/exec "$binary"
On 2009/10/14 20:24:22, Lei Zhang wrote:
> On 2009/10/14 19:50:41, Evan Stade wrote:
> > On 2009/10/14 19:42:38, Lei Zhang wrote:
> > > On 2009/10/14 19:04:37, Evan Stade wrote:
> > > > why no %U here?
> > > 
> > > Because it's %s on Gnome. I'll change kde to use %U too. See
> > > http://kb.mozillazine.org/Setting_Your_Default_Browser
> > 
> > well, you didn't put %s either
> 
> It doesn't do that either if you set a browser as the default in the UI.
> Gnome-open only looks at the url-handlers, it seems.

Yeah, when you have a URL to open it should only look at the URL handler. This
key is used to open "a web browser" without any particular URL in mind. At
least, that's what I remember being the case when I wrote this.