Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 274040: More style nits. (Closed)

Created:
11 years, 2 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

More style nits. (Working on cleaning chrome/ so hopefully we can lint it by default.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28971

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -146 lines) Patch
M chrome/browser/autocomplete/autocomplete.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_folder_tree_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/chrome_url_data_manager.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_thumbnail_source.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/downloads_dom_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/downloads_dom_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/fileicon_source.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/history_ui.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/html_dialog_ui.h View 3 chunks +22 lines, -21 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/shown_sections_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_process_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_startup_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 2 chunks +8 lines, -8 lines 1 comment Download
M chrome/browser/gtk/back_forward_menu_model_gtk.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/gtk/bookmark_context_menu_gtk.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/download_started_animation_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/extension_shelf_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/external_protocol_dialog_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/gtk_theme_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/info_bubble_gtk.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/gtk/menu_gtk.h View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/gtk/options/fonts_page_gtk.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/gtk/options/general_page_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/options_layout_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/passwords_exceptions_window_gtk.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/gtk/options/url_picker_dialog_gtk.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/hang_monitor/hung_plugin_action.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/hang_monitor/hung_window_detector.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/history/history_types.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/page_usage_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/query_parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/history/snippet_unittest.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/history/starred_url_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/url_database_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/history/visit_log_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/visit_tracker_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/in_process_webkit/dom_storage_uitest.cc View 4 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/net/url_fixer_upper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_fixer_upper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/url_request_tracking.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_job.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/printing/print_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_layout_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/privacy_blacklist/blacklist_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/privacy_blacklist/blocked_response.cc View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/sessions/session_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/interstitial_page.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/navigation_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/navigation_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/navigation_entry.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_delegate.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/view_source_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drag_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/web_drop_target.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/visitedlink_master.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
(This is a deceptively easy code review. It's almost all whitespace with the occasional explicit ...
11 years, 2 months ago (2009-10-14 01:27:04 UTC) #1
brettw
11 years, 2 months ago (2009-10-14 02:08:50 UTC) #2
LGTM

http://codereview.chromium.org/274040/diff/1/21
File chrome/browser/extensions/user_script_listener_unittest.cc (right):

http://codereview.chromium.org/274040/diff/1/21#newcode34
Line 34: : UserScriptMaster(worker, script_dir) { }
Since you're here, no space in the {}

http://codereview.chromium.org/274040/diff/1/29
File chrome/browser/gtk/menu_gtk.h (right):

http://codereview.chromium.org/274040/diff/1/29#newcode39
Line 39: virtual void StoppedShowing() { }
Ditto

http://codereview.chromium.org/274040/diff/1/55
File chrome/browser/privacy_blacklist/blocked_response.cc (right):

http://codereview.chromium.org/274040/diff/1/55#newcode104
Line 104: }  // end namespace chrome
Can you fix this comment while you're at it?

Powered by Google App Engine
This is Rietveld 408576698