Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 274028: Don't hide task manager key binding from web pages. (Closed)

Created:
11 years, 2 months ago by Michael Moss
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting, jam
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Don't hide task manager key binding from web pages. This allows shift-esc to work again in Gmail chat windows. BUG=none TEST=Open Gmail, start a chat, repeatedly press SHIFT+ESC and watch it switch between the chat "window" and the mail list. The Task Manager should not open.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/browser.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Michael Moss
11 years, 2 months ago (2009-10-13 21:04:36 UTC) #1
jam
lgtm
11 years, 2 months ago (2009-10-13 21:11:12 UTC) #2
Peter Kasting
Is there a BUG= or TEST= that applies here?
11 years, 2 months ago (2009-10-13 21:12:58 UTC) #3
Michael Moss
I suppose Bug 5496, which this was originally added for, might apply? The tests included ...
11 years, 2 months ago (2009-10-13 21:23:03 UTC) #4
Peter Kasting
On 2009/10/13 21:23:03, mmoss wrote: > I suppose Bug 5496, which this was originally added ...
11 years, 2 months ago (2009-10-13 21:24:30 UTC) #5
Michael Moss
> I meant, was there a bug on shift-esc not working in gmail chat windows. ...
11 years, 2 months ago (2009-10-13 21:38:30 UTC) #6
Michael Moss
Peter, are you OK with this?
11 years, 2 months ago (2009-10-14 17:53:53 UTC) #7
Peter Kasting
11 years, 2 months ago (2009-10-14 17:55:11 UTC) #8
On 2009/10/14 17:53:53, mmoss wrote:
> Peter, are you OK with this?

You don't need my sign-off, I just dropped by to ask for BUG= and TEST=.  You
should always put both on all patches.  Put "none" in for either if there is
nothing applicable.

Powered by Google App Engine
This is Rietveld 408576698