Issue 274012: Convert BlockFiles to use FilePath instead of wstring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 274012: Convert BlockFiles to use FilePath instead of wstring. (Closed)

Created:
11 years, 2 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Convert BlockFiles to use FilePath instead of wstring. BUG=24444 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28873

Patch Set 2 : rebase #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -49 lines)			Patch
M	net/disk_cache/backend_impl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/disk_cache/block_files.h	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	net/disk_cache/block_files.cc	View	4 chunks	+12 lines, -15 lines	0 comments	Download
M	net/disk_cache/block_files_unittest.cc	View	7 chunks	+15 lines, -16 lines	0 comments	Download
M	net/disk_cache/cache_util.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/disk_cache/cache_util_posix.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	net/disk_cache/cache_util_win.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	net/disk_cache/disk_cache_perftest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/disk_cache/disk_cache_test_util.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/disk_cache/disk_cache_test_util.cc	View	2 chunks	+6 lines, -1 line	1 comment	Download
M	net/tools/dump_cache/dump_files.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

LGTM http://codereview.chromium.org/274012/diff/2001/3009 File net/disk_cache/disk_cache_test_util.cc (right): http://codereview.chromium.org/274012/diff/2001/3009#newcode8 Line 8: #include "base/file_path.h" I haven't bothered to put ...

11 years, 2 months ago (2009-10-13 20:15:54 UTC) #2

OK

Expand Messages | Collapse Messages

Issue 274012: Convert BlockFiles to use FilePath instead of wstring. (Closed)

Description

Patch Set 1 #

Patch Set 2 : rebase #

Messages