Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 27370: Update clipboard classes to use string16 and FilePath instead of wstring.... (Closed)

Created:
11 years, 9 months ago by Evan Stade
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update clipboard classes to use string16 and FilePath instead of wstring. Update callers as well. This patch builds on a patch by mark.a.lindner@gmail.com which can be found at http://codereview.chromium.org/28294 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10860

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -138 lines) Patch
base/clipboard.h View 1 2 4 chunks +11 lines, -7 lines 0 comments Download
M base/clipboard_linux.cc View 1 2 4 chunks +10 lines, -6 lines 0 comments Download
M base/clipboard_mac.mm View 1 2 7 chunks +16 lines, -16 lines 0 comments Download
base/clipboard_unittest.cc View 1 2 11 chunks +28 lines, -26 lines 0 comments Download
base/clipboard_win.cc View 1 2 3 13 chunks +22 lines, -23 lines 0 comments Download
M base/pickle.h View 2 3 chunks +3 lines, -0 lines 0 comments Download
M base/pickle.cc View 2 2 chunks +25 lines, -1 line 0 comments Download
M base/scoped_clipboard_writer.h View 1 2 2 chunks +11 lines, -6 lines 0 comments Download
M base/scoped_clipboard_writer.cc View 1 2 5 chunks +28 lines, -19 lines 0 comments Download
base/string_util.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
chrome/browser/download/download_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.h View 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_controller.h View 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_controller.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/ipc_message_utils.h View 2 1 chunk +14 lines, -0 lines 0 comments Download
chrome/common/render_messages_internal.h View 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/renderer_glue.cc View 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/simple_clipboard_impl.cc View 2 3 chunks +3 lines, -2 lines 0 comments Download
M webkit/glue/webclipboard_impl.cc View 2 4 chunks +14 lines, -13 lines 0 comments Download
M webkit/glue/webkit_glue.h View 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
The changes to base/clipboard were written by Mark Lindner and LGed by dsh and I. ...
11 years, 9 months ago (2009-03-03 18:49:22 UTC) #1
darin (slow to review)
11 years, 9 months ago (2009-03-03 19:40:57 UTC) #2
LGTM

http://codereview.chromium.org/27370/diff/2001/2003
File base/scoped_clipboard_writer.cc (right):

http://codereview.chromium.org/27370/diff/2001/2003#newcode99
Line 99: const char *data = reinterpret_cast<const char *>(filename.data());
nit: |const char*| <- note the spacing

Powered by Google App Engine
This is Rietveld 408576698