Fixes to gyp files to get test_shell building on windows from a gyp project (...

Fixes to gyp files to get test_shell building on windows from a gyp project (doesn't run correctly yet).
Switched all uses of windows system libraries that assumed they were in the include path to use -l (which will be
supported on windows in a separate change).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10781

[Mark Mentovai, 2009-03-03 00:15:56]

LGTM with a couple minor changes.

Please feed your final patch to the tryserver to validate the Mac build now that
we're relying on the .gyp files.

http://codereview.chromium.org/27362/diff/1/7
File breakpad/breakpad.gyp (right):

http://codereview.chromium.org/27362/diff/1/7#newcode14
Line 14: 'src\client\windows\crash_generation\client_info.cc',
Please use forward slashes in all .gyp files.

http://codereview.chromium.org/27362/diff/1/5
File webkit/activex_shim_dll/activex_shim_dll.gyp (right):

http://codereview.chromium.org/27362/diff/1/5#newcode28
Line 28: 'urlmon.lib',
This is going to have relativization applied to it, which isn't right, right?

http://codereview.chromium.org/27362/diff/1/2
File webkit/webkit.gyp (right):

http://codereview.chromium.org/27362/diff/1/2#newcode1049
Line 1049: 'port/bindings/v8/ScriptController.cpp',
Take this out, it duplicates lines 1037-1038 above.

http://codereview.chromium.org/27362/diff/1/2#newcode3745
Line 3745: ['exclude',
'/(android|cairo|cf|cg|curl|gtk|linux|mac|posix|qt|soup|symbian|win|wx)/'],
Since we exclude all dirs like win and mac and linux, I think we should retain
the exclude of opentype and explicitly re-include it on the platforms we want it
on, instead of just excluding it on the Mac.

[bradn, 2009-03-03 00:45:11]

Have another look.

http://codereview.chromium.org/27362/diff/1/7
File breakpad/breakpad.gyp (right):

http://codereview.chromium.org/27362/diff/1/7#newcode14
Line 14: 'src\client\windows\crash_generation\client_info.cc',
On 2009/03/03 00:15:56, Mark Mentovai wrote:
> Please use forward slashes in all .gyp files.

Done.

http://codereview.chromium.org/27362/diff/1/5
File webkit/activex_shim_dll/activex_shim_dll.gyp (right):

http://codereview.chromium.org/27362/diff/1/5#newcode28
Line 28: 'urlmon.lib',
On 2009/03/03 00:15:56, Mark Mentovai wrote:
> This is going to have relativization applied to it, which isn't right, right?

Moved it into link_settings, is this what you meant?

http://codereview.chromium.org/27362/diff/1/2
File webkit/webkit.gyp (right):

http://codereview.chromium.org/27362/diff/1/2#newcode1049
Line 1049: 'port/bindings/v8/ScriptController.cpp',
On 2009/03/03 00:15:56, Mark Mentovai wrote:
> Take this out, it duplicates lines 1037-1038 above.

Done.

http://codereview.chromium.org/27362/diff/1/2#newcode3745
Line 3745: ['exclude',
'/(android|cairo|cf|cg|curl|gtk|linux|mac|posix|qt|soup|symbian|win|wx)/'],
On 2009/03/03 00:15:56, Mark Mentovai wrote:
> Since we exclude all dirs like win and mac and linux, I think we should retain
> the exclude of opentype and explicitly re-include it on the platforms we want
it
> on, instead of just excluding it on the Mac.

Done.