Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: counter.h

Issue 2736008: Measure and report time between user-space process crashes. (Closed) Base URL: ssh://git@chromiumos-git/metrics.git
Patch Set: No need to start the back off again on crashes. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | counter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: counter.h
diff --git a/counter.h b/counter.h
index aac00af730e0716950d0506083a0cdc9c5310572..876b107323c7c18863098a46c1ab363cd41917a5 100644
--- a/counter.h
+++ b/counter.h
@@ -22,8 +22,7 @@ class TaggedCounterInterface {
public:
// Callback type used for reporting aggregated or flushed data.
// Once this callback is invoked by the counter, the reported
- // aggregated data is discarded. Only aggregated data with positive
- // counts is reported.
+ // aggregated data is discarded.
//
// |handle| is the |reporter_handle| pointer passed through Init.
// |tag| is the tag associated with the aggregated count.
@@ -124,8 +123,9 @@ class TaggedCounter : public TaggedCounterInterface {
// Updates the cached record given the new |tag| and |count|. This
// method expects either a null cached record, or a valid cached
- // record with the same tag as |tag|.
- void UpdateRecord(int tag, int count);
+ // record with the same tag as |tag|. If |flush| is true, the method
+ // asserts that the cached record is null and returns.
+ void UpdateRecord(int tag, int count, bool flush);
// If the cached record state is dirty, updates the persistent
// storage specified through file descriptor |fd| and switches the
« no previous file with comments | « no previous file | counter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698