Issue 2735005: Merge 49197 - Submitting CL http://codereview.chromium.org/2324001 on behalf ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2735005: Merge 49197 - Submitting CL http://codereview.chromium.org/2324001 on behalf ... (Closed)

Created:
10 years, 6 months ago by oritm

Modified:
9 years, 4 months ago

Reviewers:
zel

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/branches/418/src/

Visibility:
Public.

Merge 49197 - Submitting CL http://codereview.chromium.org/2324001 on behalf of petkov@chromium.org: Add the hardwareclass UMA log field for Chrome OS builds. This field will be used to distinguish histograms across Chrome OS hardware platforms. BUG=none TEST=unit tests, tested on target device by reviewing the logs Review URL: http://codereview.chromium.org/2738003 TBR=zelidrag@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49205

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+187 lines, -48 lines)			Patch
M	chrome/browser/metrics/metrics_log.h	View	5 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/browser/metrics/metrics_log.cc	View	7 chunks	+45 lines, -7 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log_unittest.cc	View	4 chunks	+35 lines, -4 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service.h	View	4 chunks	+23 lines, -7 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service.cc	View	10 chunks	+61 lines, -28 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service_unittest.cc	View	2 chunks	+11 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM