Issue 2735004: Uses TPM return codes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2735004: Uses TPM return codes. (Closed)

Created:
10 years, 6 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
Luigi Semenzato, Bill Richardson, gauravsh

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org/vboot_reference.git

Visibility:
Public.

Description

Uses TPM return codes. Rollback_index funcs now all return 0 if succcess, nonzero if error. (Note: not fully implemented; Luigi, please clean this up in a subsequent CL) LoadKernel() checks return codes from TPM funcs. LoadKernel() only looks at versions from TPM in normal boot mode.

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -72 lines)			Patch
M	tests/rollback_index_mock.c	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	vboot_firmware/include/rollback_index.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	vboot_firmware/lib/load_kernel_fw.c	View	6 chunks	+68 lines, -48 lines	0 comments	Download
M	vboot_firmware/lib/rollback_index.c	View	4 chunks	+27 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

10 years, 6 months ago (2010-06-08 22:37:37 UTC) #2

LGTM.

No point in nitpicking, since there are massive collisions with my upcoming
change :-)

Expand Messages | Collapse Messages