Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: third_party/WebKit/WebCore/platform/KURLGoogle.cpp

Issue 27342: Make KURLGoogle match webkit's query string parsing.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/WebCore/page/Location.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/WebCore/platform/KURLGoogle.cpp
===================================================================
--- third_party/WebKit/WebCore/platform/KURLGoogle.cpp (revision 10557)
+++ third_party/WebKit/WebCore/platform/KURLGoogle.cpp (working copy)
@@ -520,15 +520,8 @@
String KURL::query() const
{
- if (m_url.m_parsed.query.len >= 0) {
- // KURL's query() includes the question mark, even though the reference
- // doesn't. Move the query component backwards one to account for it
- // (our library doesn't count the question mark).
- url_parse::Component queryComp = m_url.m_parsed.query;
- queryComp.begin--;
- queryComp.len++;
- return m_url.componentString(queryComp);
- }
+ if (m_url.m_parsed.query.len >= 0)
+ return m_url.componentString(m_url.m_parsed.query);
// Bug: https://bugs.webkit.org/show_bug.cgi?id=21015 this function returns
// an empty string when the query is empty rather than a null (not sure
« no previous file with comments | « third_party/WebKit/WebCore/page/Location.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698