Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: src/arm/debug-arm.cc

Issue 2733006: ARM: Fix bug in r4820 related to code for additional break positions.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/assembler-arm-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 256
257 void Debug::GenerateStubNoRegistersDebugBreak(MacroAssembler* masm) { 257 void Debug::GenerateStubNoRegistersDebugBreak(MacroAssembler* masm) {
258 // ----------- S t a t e ------------- 258 // ----------- S t a t e -------------
259 // No registers used on entry. 259 // No registers used on entry.
260 // ----------------------------------- 260 // -----------------------------------
261 Generate_DebugBreakCallHelper(masm, 0); 261 Generate_DebugBreakCallHelper(masm, 0);
262 } 262 }
263 263
264 264
265 void Debug::GenerateSlot(MacroAssembler* masm) { 265 void Debug::GenerateSlot(MacroAssembler* masm) {
266 // Generate enough nop's to make space for a call instruction. 266 // Generate enough nop's to make space for a call instruction. Avoid emitting
267 // the constant pool in the debug break slot code.
268 Assembler::BlockConstPoolScope block_const_pool(masm);
267 Label check_codesize; 269 Label check_codesize;
268 __ bind(&check_codesize); 270 __ bind(&check_codesize);
269 __ RecordDebugBreakSlot(); 271 __ RecordDebugBreakSlot();
270 for (int i = 0; i < Assembler::kDebugBreakSlotInstructions; i++) { 272 for (int i = 0; i < Assembler::kDebugBreakSlotInstructions; i++) {
271 __ nop(2); 273 __ nop(2);
272 } 274 }
273 ASSERT_EQ(Assembler::kDebugBreakSlotInstructions, 275 ASSERT_EQ(Assembler::kDebugBreakSlotInstructions,
274 masm->InstructionsGeneratedSince(&check_codesize)); 276 masm->InstructionsGeneratedSince(&check_codesize));
275 } 277 }
276 278
(...skipping 21 matching lines...) Expand all
298 Handle<Code> code) { 300 Handle<Code> code) {
299 UNREACHABLE(); 301 UNREACHABLE();
300 } 302 }
301 const int Debug::kFrameDropperFrameSize = -1; 303 const int Debug::kFrameDropperFrameSize = -1;
302 304
303 #endif // ENABLE_DEBUGGER_SUPPORT 305 #endif // ENABLE_DEBUGGER_SUPPORT
304 306
305 } } // namespace v8::internal 307 } } // namespace v8::internal
306 308
307 #endif // V8_TARGET_ARCH_ARM 309 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/assembler-arm-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698