Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 27330: Unify the handling of the event and response JSON in developer shell debugger... (Closed)

Created:
11 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Unify the handling of the event and response JSON in developer shell debugger. Formatting of both debugger events and debugger responses are now unified into one function. This is mainly in preparation for the upcomming remote debugging support where having it a one function simplify things. Committed: http://code.google.com/p/v8/source/detail?r=1399

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -75 lines) Patch
M src/d8.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/d8.cc View 2 chunks +4 lines, -22 lines 0 comments Download
M src/d8.js View 2 chunks +56 lines, -46 lines 0 comments Download
M src/d8-debug.cc View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 9 months ago (2009-03-02 15:12:00 UTC) #1
Mads Ager (chromium)
11 years, 9 months ago (2009-03-02 16:03:15 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698