Issue 2731006: ... - Code Review

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2731006: ... (Closed)

Created:
10 years, 6 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Relanding this CL as the earlier attempt broke ChromeOS metrics tests. Preparation CL for adding crash metrics UMA counters to ChromeFrame. Basically this would mean that metrics reporting would be done directly by ChromeFrame. Currently ChromeFrame uses Chrome to upload this data. Refactored the chrome metrics service and metrics logging functionality into base classes defined in chrome\common\metrics_helpers.cc/.h. While this refactoring is by no means complete it is a first step to avoid needless code duplication between chrome and chrome frame. Bug=46057 TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49417

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -650 lines)			Patch
M	chrome/browser/metrics/metrics_log.h	View	1 2	5 chunks	+8 lines, -141 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log.cc	View	1 2	3 chunks	+20 lines, -360 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service.h	View	1 2	9 chunks	+4 lines, -36 lines	0 comments	Download
M	chrome/browser/metrics/metrics_service.cc	View	1 2	8 chunks	+12 lines, -111 lines	0 comments	Download
M	chrome/chrome_common.gypi	View		2 chunks	+3 lines, -0 lines	0 comments	Download
A +	chrome/common/metrics_helpers.h	View		3 chunks	+11 lines, -0 lines	0 comments	Download
A +	chrome/common/metrics_helpers.cc	View		6 chunks	+45 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

amit

10 years, 6 months ago (2010-06-10 17:59:54 UTC) #2

rubber stamp lgtm. 
Please run this by relevant CrOS person if necessary.

Expand Messages | Collapse Messages

Issue 2731006: ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages