Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 273073: Remove special case for arguments.toString to match ES5

Created:
11 years, 2 months ago by Jan de Mooij
Modified:
11 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Remove special-case for arguments.toString to match ES5 See ES5 10.6 and Annex E. Webkit has this change already.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M src/v8natives.js View 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/regress/regress-124.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jan de Mooij
Hi Christian, 'svn blame' shows last change here was from Mads Ager, but he is ...
11 years, 2 months ago (2009-10-15 20:52:42 UTC) #1
Christian Plesner Hansen
Lgtm. And feel free to send any ES5-related changes to me.
11 years, 2 months ago (2009-10-16 07:43:11 UTC) #2
Jan de Mooij
On 2009/10/16 07:43:11, Christian Plesner Hansen wrote: > Lgtm. And feel free to send any ...
11 years, 1 month ago (2009-11-09 12:52:56 UTC) #3
Christian Plesner Hansen
11 years, 1 month ago (2009-11-11 11:31:39 UTC) #4
Sorry, I forgot all about this; landed in
http://code.google.com/p/v8/source/detail?r=3279.  Thanks for the patch!

Powered by Google App Engine
This is Rietveld 408576698