Initial infrastructure for fast compilation of top-level code. The...

Initial infrastructure for fast compilation of top-level code.  The
fast code generator is optimized for compilation time and code size.

Currently it is only implemented on IA32.  It is potentially triggered
for any code in the global scope (including code eval'd in the global
scope).  It performs a syntactic check and chooses to compile in fast
mode if the AST contains only supported constructs and matches some
other constraints.

Initially supported constructs are

* ExpressionStatement,
* ReturnStatement,
* VariableProxy (variable references) to parameters and
    stack-allocated locals,
* Assignment with lhs a parameter or stack-allocated local, and
* Literal

This allows compilation of literals at the top level and not much
else.

All intermediate values are allocated to temporaries and the stack is
used for all temporaries.  The extra memory traffic is a known issue.

The code generated for 'true' is:

 0  push ebp
 1  mov ebp,esp
 3  push esi
 4  push edi
 5  push 0xf5cca135             ;; object: 0xf5cca135 <undefined>
10  cmp esp,[0x8277efc]
16  jnc 27  (0xf5cbbb1b)
22  call 0xf5cac960             ;; code: STUB, StackCheck, minor: 0
27  push 0xf5cca161             ;; object: 0xf5cca161 <true>
32  mov eax,[esp]
35  mov [ebp+0xf4],eax
38  pop eax
39  mov eax,[ebp+0xf4]
42  mov esp,ebp                 ;; js return
44  pop ebp
45  ret 0x4
48  mov eax,0xf5cca135          ;; object: 0xf5cca135 <undefined>
53  mov esp,ebp                 ;; js return
55  pop ebp
56  ret 0x4


Committed: http://code.google.com/p/v8/source/detail?r=3067

[Kevin Millikin (Chromium), 2009-10-14 14:06:18]

http://codereview.chromium.org/273050/diff/1/7
File src/compiler.cc (right):

http://codereview.chromium.org/273050/diff/1/7#newcode460
Line 460: CHECK(!(scope->is_global_scope() && scope->num_heap_slots() > 0));
Oops, this line will be completely removed before committing.

[fschneider, 2009-10-14 14:15:13]

1 comment, otherwise LGTM.

http://codereview.chromium.org/273050/diff/1/5
File src/flag-definitions.h (right):

http://codereview.chromium.org/273050/diff/1/5#newcode147
Line 147: "print reasons for failing to use fast compilation")
Maybe we want a flag to switch off the fast code generator completely to be able
to compare performance+code size with the normal compiler?

[Kevin Millikin (Chromium), 2009-10-14 14:25:10]

On 2009/10/14 14:15:13, fschneider wrote:
> 1 comment, otherwise LGTM.
> 
> http://codereview.chromium.org/273050/diff/1/5
> File src/flag-definitions.h (right):
> 
> http://codereview.chromium.org/273050/diff/1/5#newcode147
> Line 147: "print reasons for failing to use fast compilation")
> Maybe we want a flag to switch off the fast code generator completely to be
able
> to compare performance+code size with the normal compiler?

Good idea.  I've added --fast-compiler which is enabled by default
(--nofast-compiler to disable).

[William Hesse, 2009-10-14 14:51:12]

LGTM.

http://codereview.chromium.org/273050/diff/1/3
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/273050/diff/1/3#newcode39
Line 39: void FastCodeGenerator::Generate(FunctionLiteral* fun) {
Either here, or in the declaration of the function, I would like to see the
information about the expected state when the generated function is called, and
the stack frame set up by this function.