Issue 27305: Check the return value of fwrite....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27305: Check the return value of fwrite.... (Closed)

Created:
11 years, 9 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Check the return value of fwrite. Newer versions of glib stdio mark fwrite() with warn_unused_result

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/log.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Kevin Millikin (Chromium)

I think this will also need USE(rv); to avoid unused-variable warnings in release builds.

11 years, 9 months ago (2009-02-28 03:40:54 UTC) #2

Evan Stade

ok, thanks! Even for debug, I don't know if we actually want to assert here, ...

11 years, 9 months ago (2009-02-28 09:16:47 UTC) #3

Mads Ager (chromium)

11 years, 9 months ago (2009-02-28 13:57:50 UTC) #4

LGTM with USE(rv) added.  I'm fine with the assert.  I'll go ahead and commit
this for you.