Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 273039: New mjsunit tests for the new compiler infrastructure. They... (Closed)

Created:
11 years, 2 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

New mjsunit tests for the new compiler infrastructure. They are in a separate subdirectory called 'compiler' in the mjsunit directory. Committed: http://code.google.com/p/v8/source/detail?r=3061

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -1 line) Patch
A test/mjsunit/compiler/literals.js View 1 1 chunk +35 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/literals-assignment.js View 1 1 chunk +71 lines, -0 lines 0 comments Download
M test/mjsunit/testcfg.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
11 years, 2 months ago (2009-10-13 17:35:28 UTC) #1
Kevin Millikin (Chromium)
LGTM, but you may want to 'inline' (as strings passed to eval) the bodies of ...
11 years, 2 months ago (2009-10-14 08:29:01 UTC) #2
fschneider
11 years, 2 months ago (2009-10-14 09:19:07 UTC) #3
On 2009/10/14 08:29:01, Kevin Millikin wrote:
> LGTM, but you may want to 'inline' (as strings passed to eval) the bodies of
the
> functions in literals-assignment for now.
>

Done.
 
> http://codereview.chromium.org/273039/diff/1/3
> File test/mjsunit/compiler/literals-assignment.js (right):
> 
> http://codereview.chromium.org/273039/diff/1/3#newcode32
> Line 32: assertEquals(8, f1());
> This won't hit the initial compiler implementation without evaling a string
(the
> body of fl).

For now I changed the test functions to be anonymous functions applied directly.
They pass all tests.

Powered by Google App Engine
This is Rietveld 408576698