Make GetLinuxDistro thread-safe.

Make GetLinuxDistro thread-safe.

BUG=24659
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28785

[Lei Zhang, 2009-10-12 23:31:28]

My previous attempt to fix issue 21782 just made things worse. Hopefully this
will stop the crash.

[Evan Martin, 2009-10-12 23:37:07]

LGTM

http://codereview.chromium.org/273026/diff/3001/3002
File base/linux_util.cc (right):

http://codereview.chromium.org/273026/diff/3001/3002#newcode55
Line 55: DefaultSingletonTraits<LinuxDistroState> >::get();
can this not be:
   return Singleton<LinuxDistroState>::get();
?

i think the second arg is the default

http://codereview.chromium.org/273026/diff/3001/3002#newcode86
Line 86: };
For cleanliness, you can put a type on the enum instead of using ints
everywhere.

[Lei Zhang, 2009-10-13 00:10:17]

http://codereview.chromium.org/273026/diff/3001/3002
File base/linux_util.cc (right):

http://codereview.chromium.org/273026/diff/3001/3002#newcode55
Line 55: DefaultSingletonTraits<LinuxDistroState> >::get();
On 2009/10/12 23:37:07, Evan Martin wrote:
> can this not be:
>    return Singleton<LinuxDistroState>::get();
> ?
> 
> i think the second arg is the default

Done.

http://codereview.chromium.org/273026/diff/3001/3002#newcode86
Line 86: };
On 2009/10/12 23:37:07, Evan Martin wrote:
> For cleanliness, you can put a type on the enum instead of using ints
> everywhere.

Done.