Issue 273022: Fixing a bug with interstitial pages triggered with malware....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 273022: Fixing a bug with interstitial pages triggered with malware.... (Closed)

Created:
11 years, 2 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, Paul Godavari, ben+cc_chromium.org, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixing a bug with interstitial pages triggered with malware. BUG=http://crbug.com/17627 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29071

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -4 lines)			Patch
M	chrome/browser/safe_browsing/safe_browsing_blocking_page.cc	View		2 chunks	+13 lines, -4 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc	View	1	2 chunks	+45 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/navigation_controller.cc	View		2 chunks	+6 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 2 months ago (2009-10-14 20:47:09 UTC) #2

LGTM

http://codereview.chromium.org/273022/diff/2001/3003
File chrome/browser/tab_contents/navigation_controller.cc (right):

http://codereview.chromium.org/273022/diff/2001/3003#newcode664
Line 664: // If a transient entry was removed, the indeces might have changed,
get
indeces -> indices

http://codereview.chromium.org/273022/diff/2001/3003#newcode666
Line 666: entry_index =
GetEntryIndexWithPageID(tab_contents_->GetSiteInstance(),
How about skipping entry_index and just setting last_committed_entry_index_ =
GetEntryIndexWithPageID(...
(be sure to update the comment).

Expand Messages | Collapse Messages