gtk: Remember which page user viewed last in the Certificate Manager window.

gtk: Remember which page user viewed last in the Certificate Manager window.

(Note: That was a TODO for Matt).

BUG=None
TEST=open the Certificate Manager window, select a tab, close it, open again, it
should opens in the tab you viewed last.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49848

[tfarina, 2010-06-12 03:53:49]

Hi Matt, could you review this to me?

I tested it on my linux box with the diff you sent to me (I just had to do a
small modification on the call to ShowCertificateManager. The modifications in
the advanced_content_page.cc are not included in this CL for know reasons :) ).

[mattm, 2010-06-15 01:28:45]

http://codereview.chromium.org/2730016/diff/2001/3002
File chrome/browser/gtk/certificate_manager.cc (right):

http://codereview.chromium.org/2730016/diff/2001/3002#newcode516
chrome/browser/gtk/certificate_manager.cc:516: manager->Show();
the Show() method is no longer necessary since the constructor does the showing
now.

http://codereview.chromium.org/2730016/diff/2001/3004
File chrome/common/pref_names.cc (right):

http://codereview.chromium.org/2730016/diff/2001/3004#newcode889
chrome/common/pref_names.cc:889: L"certificate_manager_window.last_tab_index";
Looks like this should go above, in the profile prefs section.

[tfarina, 2010-06-15 02:37:37]

Please, take another look.

http://codereview.chromium.org/2730016/diff/2001/3002
File chrome/browser/gtk/certificate_manager.cc (right):

http://codereview.chromium.org/2730016/diff/2001/3002#newcode516
chrome/browser/gtk/certificate_manager.cc:516: manager->Show();
On 2010/06/15 01:28:46, mattm wrote:
> the Show() method is no longer necessary since the constructor does the
showing
> now.
Good catch, removed.

http://codereview.chromium.org/2730016/diff/2001/3004
File chrome/common/pref_names.cc (right):

http://codereview.chromium.org/2730016/diff/2001/3004#newcode889
chrome/common/pref_names.cc:889: L"certificate_manager_window.last_tab_index";
On 2010/06/15 01:28:46, mattm wrote:
> Looks like this should go above, in the profile prefs section.

Moved above, near of the others LastTabIndex.

[mattm, 2010-06-15 03:06:01]

LGTM, thanks

[tfarina, 2010-06-15 22:53:20]

On 2010/06/15 03:06:01, mattm wrote:
> LGTM, thanks

Committing now...