Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Unified Diff: chrome/browser/cocoa/browser_window_controller.mm

Issue 2730015: Mac/clang: Uncontentious fixes. (Closed)
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/cocoa/browser_window_controller.mm b/chrome/browser/cocoa/browser_window_controller.mm
index fa33dfb0b7687c198b87e09c018de122a4cd8d3d..4b57df7968442c64da86628080ee3c13b23f9243 100644
--- a/chrome/browser/cocoa/browser_window_controller.mm
+++ b/chrome/browser/cocoa/browser_window_controller.mm
@@ -1473,14 +1473,15 @@
- (void)swipeWithEvent:(NSEvent*)event {
// Map forwards and backwards to history; left is positive, right is negative.
unsigned int command = 0;
- if ([event deltaX] > 0.5)
+ if ([event deltaX] > 0.5) {
command = IDC_BACK;
- else if ([event deltaX] < -0.5)
+ } else if ([event deltaX] < -0.5) {
command = IDC_FORWARD;
- else if ([event deltaY] > 0.5)
- ; // TODO(pinkerton): figure out page-up, http://crbug.com/16305
- else if ([event deltaY] < -0.5)
- ; // TODO(pinkerton): figure out page-down, http://crbug.com/16305
+ } else if ([event deltaY] > 0.5) {
+ // TODO(pinkerton): figure out page-up, http://crbug.com/16305
Mark Mentovai 2010/06/11 18:47:35 Wow.
+ } else if ([event deltaY] < -0.5) {
+ // TODO(pinkerton): figure out page-down, http://crbug.com/16305
+ }
// Ensure the command is valid first (ExecuteCommand() won't do that) and
// then make it so.

Powered by Google App Engine
This is Rietveld 408576698