Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2729010: Fix chrome build inside the Chromium OS build chroot. (Closed)

Created:
10 years, 6 months ago by satorux1
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews, Yusuke Sato
Visibility:
Public.

Description

Fix chrome build inside the Chromium OS build chroot. In the chroot used for building Chromium OS, gnome-keyring is not installed so the gyp fails with the errors like: Exception: Call to 'pkg-config --cflags gnome-keyring-1' returned exit status 1. while loading dependencies of src/base/base.gyp while loading dependencies of src/net/net.gyp while loading dependencies of src/app/app.gyp while loading dependencies of src/build/all.gyp while trying to load src/build/all.gyp failed to run command: /usr/bin/python src/build/gyp_chromium BUG=chromium-os:4000 TEST=Tested on Ubuntu and in the chroot: On Ubuntu: % sudo apt-get remove libgnome-keyring-dev % GYP_DEFINES="chromeos=0" gclient runhooks' ... gyp fails as libgnome-keyring-dev is not installed ... % GYP_DEFINES="chromeos=1" gclient runhooks' ... gyp succeeds ... In the chromium os build chroot: % emerge-x86-generic chromeos-chrome ... gyp suceeds ... Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M build/linux/system.gyp View 1 chunk +26 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
10 years, 6 months ago (2010-06-10 07:33:08 UTC) #1
tony
10 years, 6 months ago (2010-06-10 07:42:00 UTC) #2
LGTM.  It might be a bit cleaner to just put the gnome-keyring target in the
conditions block at the very top of the file with a chromeos==0 condition, but
this is OK too.

Powered by Google App Engine
This is Rietveld 408576698