Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: webkit/support/test_webplugin_page_delegate.h

Issue 2729004: Move npapi_layout_test_plugin target to webkit_support to use it from... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | webkit/support/webkit_support.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/support/test_webplugin_page_delegate.h
===================================================================
--- webkit/support/test_webplugin_page_delegate.h (revision 49234)
+++ webkit/support/test_webplugin_page_delegate.h (working copy)
@@ -7,6 +7,7 @@
#include <string>
+#include "webkit/glue/plugins/webplugin_delegate_impl.h"
#include "webkit/glue/plugins/webplugin_page_delegate.h"
namespace webkit_support {
@@ -18,7 +19,11 @@
virtual webkit_glue::WebPluginDelegate* CreatePluginDelegate(
const FilePath& file_path,
- const std::string& mime_type) { return NULL; }
+ const std::string& mime_type) {
+ // We don't need a valid native window handle in layout tests.
+ // So just passing 0.
+ return WebPluginDelegateImpl::Create(file_path, mime_type, 0);
+ }
virtual void CreatedPluginWindow(gfx::PluginWindowHandle handle) {}
virtual void WillDestroyPluginWindow(gfx::PluginWindowHandle handle) {}
virtual void DidMovePlugin(const webkit_glue::WebPluginGeometry& move) {}
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | webkit/support/webkit_support.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698