Issue 27277: Ensure classes only referenced by .xib files end up in the executable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27277: Ensure classes only referenced by .xib files end up in the executable (Closed)

Created:
11 years, 10 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs), TVL

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Ensure classes only referenced by .xib files end up in the executable Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10619

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+179 lines, -6 lines)			Patch
A	build/mac/make_ib_classes.py	View	1 2	1 chunk	+140 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_controller.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View		5 chunks	+37 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

This does what it's supposed to do. Independently, I found a problem with Xcode's dependency ...

11 years, 10 months ago (2009-02-27 19:05:56 UTC) #1

TVL

11 years, 10 months ago (2009-02-27 19:19:21 UTC) #2

lgtm

http://codereview.chromium.org/27277/diff/1/2
File build/mac/make_ib_classes.py (right):

http://codereview.chromium.org/27277/diff/1/2#newcode99
Line 99: (script_path, output_path) = args[0:2]
do you want to make sure output_path ends in .mm?

Expand Messages | Collapse Messages