Issue 27269: Align code entry points to 32 bytes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27269: Align code entry points to 32 bytes. (Closed)

Created:
11 years, 10 months ago by iposva

Modified:
9 years, 3 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Align code entry points to 32 bytes. Committed: http://code.google.com/p/v8/source/detail?r=1386

Patch Set 1 #

Total comments: 6

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -4 lines)			Patch
M	src/heap.cc	View	1 chunk	+1 line, -0 lines	4 comments	Download
M	src/objects.h	View	2 chunks	+7 lines, -2 lines	2 comments	Download
M	src/objects-inl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/27269/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/27269/diff/1/2#newcode1634 Line 1634: ASSERT((obj_size % Code::kCodeAlignment) == 0); IsAligned(obj_size, Code::kCodeAlignment) ...

11 years, 10 months ago (2009-02-27 10:32:11 UTC) #2

iposva

11 years, 10 months ago (2009-02-27 11:08:28 UTC) #3

http://codereview.chromium.org/27269/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/27269/diff/1/2#newcode1634
Line 1634: ASSERT((obj_size % Code::kCodeAlignment) == 0);
On 2009/02/27 10:32:11, Kasper Lund wrote:
> IsAligned(obj_size, Code::kCodeAlignment) would be easier to read.

Done.

http://codereview.chromium.org/27269/diff/1/2#newcode1669
Line 1669: return code;
On 2009/02/27 10:32:11, Kasper Lund wrote:
> It would be nice if you could assert that the entry point (instruction start)
is
> aligned the way you want it.

Done now as part of CodeVerify().

http://codereview.chromium.org/27269/diff/1/3
File src/objects.h (right):

http://codereview.chromium.org/27269/diff/1/3#newcode2282
Line 2282: static const int kFiller6Offset = kKindSpecificFlagsOffset +
kIntSize;
On 2009/02/27 10:32:11, Kasper Lund wrote:
> Comment on why you need fillers here?

Done.

Expand Messages | Collapse Messages