Reverting this as it caused installer_unit_tests to fail. Please fix and rela...

Reverting this as it caused installer_unit_tests to fail. Please fix and reland.

Revert 49346 - Fix problem whereby the "-full" magic value is removed from the "ap" value when a differential update for CF fails (it should remain unless the update succeeds).

Also, fix problem with installer return codes being squashed. This was a regression introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=41322.

BUG=46051, 40607
TEST=Cause a differential update to fail, observe that the "ap" value contains a "-full".


Review URL: http://codereview.chromium.org/2773002

TBR=robertshield@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49359

[robert, 2010-06-10 10:36:40]

ugh, thanks Ananta. The tests run fine locally :-( will try again this
morning.

On Wed, Jun 9, 2010 at 11:17 PM, <ananta@chromium.org> wrote:

> Reviewers: robertshield,
>
> Description:
> Reverting this as it caused installer_unit_tests to fail. Please fix and
> reland.
>
> Revert 49346 - Fix problem whereby the "-full" magic value is removed from
> the
> "ap" value when a differential update for CF fails (it should remain unless
> the
> update succeeds).
>
> Also, fix problem with installer return codes being squashed. This was a
> regression introduced in
> http://src.chromium.org/viewvc/chrome?view=rev&revision=41322.
>
> BUG=46051,40607
> TEST=Cause a differential update to fail, observe that the "ap" value
> contains a
> "-full".
>
>
> Review URL: http://codereview.chromium.org/2773002
>
> TBR=robertshield@chromium.org
>
> Please review this at http://codereview.chromium.org/2725007/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/installer/setup/setup_main.cc
>  M     chrome/installer/util/chrome_frame_distribution.cc
>  M     chrome/installer/util/google_chrome_distribution.h
>  M     chrome/installer/util/google_chrome_distribution.cc
>  M     chrome/installer/util/google_chrome_distribution_unittest.cc
>  M     chrome/installer/util/google_update_settings.h
>  M     chrome/installer/util/google_update_settings.cc
>  M     chrome/installer/util/google_update_settings_unittest.cc
>  M     chrome/installer/util/install_util.cc
>
>
>