Issue 27249: Make firefox_importer_utils.cc compile on Posix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27249: Make firefox_importer_utils.cc compile on Posix. (Closed)

Created:
11 years, 10 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Make firefox_importer_utils.cc compile on Posix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10564

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+95 lines, -41 lines)			Patch
M	chrome/browser/browser.scons	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/importer/firefox_importer_utils.h	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/importer/firefox_importer_utils.cc	View	17 chunks	+76 lines, -34 lines	0 comments	Download
M	chrome/browser/importer/importer.cc	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome.xcodeproj/project.pbxproj	View	4 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Evan Martin

It seems weird to bring in this file without its unit test passing. What do ...

11 years, 10 months ago (2009-02-27 00:51:03 UTC) #2

James Hawkins

On 2009/02/27 00:51:03, Evan Martin wrote: > It seems weird to bring in this file ...

11 years, 10 months ago (2009-02-27 01:03:47 UTC) #3

LG on the .gyp file.