Issue 27247: Non-functional cleanup:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27247: Non-functional cleanup:... (Closed)

Created:
11 years, 10 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Non-functional cleanup: * Clarify some comments. * Simplify some redundant boolean logic. * Add a helper function for something a lot of callers were checking manually. * Fix lint. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10546

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -23 lines)			Patch
M	chrome/browser/views/frame/browser_view.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1	6 chunks	+15 lines, -14 lines	0 comments	Download
M	chrome/browser/views/frame/opaque_non_client_view.cc	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/views/window.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/views/window_delegate.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages