Issue 27243: Revert "Revert "ASCII <-> UTF16 conversion functions. These are just copies of WideToASCII and""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27243: Revert "Revert "ASCII <-> UTF16 conversion functions. These are just copies of WideToASCII and"" (Closed)

Created:
11 years, 10 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Revert "Revert "ASCII <-> UTF16 conversion functions. These are just copies of WideToASCII and"" This reverts commit 25b05025dae174c94e6de74fa697a3338175f957.

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -8 lines)			Patch
	M	base/string_util.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
	M	base/string_util.cc	View		2 chunks	+25 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kuchhal

Turns out brett's change wasn't fully reverted on the trunk but was reverted correctly in ...

11 years, 10 months ago (2009-02-26 23:00:11 UTC) #1

LGTM, thanks!

Expand Messages | Collapse Messages