Create a remote upgrade server to serve up images as a "proxy devserver".

Create a remote upgrade server to serve up images as a "proxy devserver".  Uses devserver in "archive mode".  This is useful in situations like the wireless test lab where the development machine is not accessible from the test machines.

[Sam Leffler, 2010-06-09 19:30:13]

http://codereview.chromium.org/2724009/diff/1/2
File src/scripts/copy_upgrade_server.sh (right):

http://codereview.chromium.org/2724009/diff/1/2#newcode50
src/scripts/copy_upgrade_server.sh:50: ssh "${FLAGS_upgrade_server}" rm -rf
"${FLAGS_dest_path}" || true
What user are we logged in as?  rm -rf ... as root is worrisome.  I assume we're
not chroot'd on the target machine?  Maybe we need to do some sanity checking of
FLAGS_dest_path? (e.g. require it to be a relative pathname)

http://codereview.chromium.org/2724009/diff/1/2#newcode64
src/scripts/copy_upgrade_server.sh:64: ssh ${FLAGS_upgrade_server} "cd
${FLAGS_dest_path}/python && tar zxf -"
Does this recipe for replicating the dev server belong in the dev server code? 
I'd also feel better if we are more careful about copying bits like src/overlays
that might pull in unintended/unused data.

http://codereview.chromium.org/2724009/diff/1/2#newcode77
src/scripts/copy_upgrade_server.sh:77: ssh "${FLAGS_upgrade_server}" "rm -f
${FLAGS_archive_dir} && mkdir -p ${FLAGS_archive_dir}"
did you mean rmdir ${FLAGS_archive_dir}?  If you meant rm -rf see above.

http://codereview.chromium.org/2724009/diff/1/2#newcode91
src/scripts/copy_upgrade_server.sh:91: ssh ${FLAGS_upgrade_server} "ln -sf
${FLAGS_archive_dir}/$file ${FLAGS_dest_path}/src/platform/dev/static"
Again this feels like it's intimately tied to the implementation of the
devserver and should be implemented in that code base; e.g. add a python
function you can call from the shell.

[Paul Stewart, 2010-06-09 20:30:54]

Addressed rm and overlay issues.

http://codereview.chromium.org/2724009/diff/1/2
File src/scripts/copy_upgrade_server.sh (right):

http://codereview.chromium.org/2724009/diff/1/2#newcode50
src/scripts/copy_upgrade_server.sh:50: ssh "${FLAGS_upgrade_server}" rm -rf
"${FLAGS_dest_path}" || true
I'll validate this directory name

http://codereview.chromium.org/2724009/diff/1/2#newcode64
src/scripts/copy_upgrade_server.sh:64: ssh ${FLAGS_upgrade_server} "cd
${FLAGS_dest_path}/python && tar zxf -"
I'm removing src/overlays.  It causes common.sh to output an error, but it is
not fatal.

http://codereview.chromium.org/2724009/diff/1/2#newcode77
src/scripts/copy_upgrade_server.sh:77: ssh "${FLAGS_upgrade_server}" "rm -f
${FLAGS_archive_dir} && mkdir -p ${FLAGS_archive_dir}"
Yes, but it's gone now.

http://codereview.chromium.org/2724009/diff/1/2#newcode91
src/scripts/copy_upgrade_server.sh:91: ssh ${FLAGS_upgrade_server} "ln -sf
${FLAGS_archive_dir}/$file ${FLAGS_dest_path}/src/platform/dev/static"
Yeah.  This is unfortunate.  However, since we are invoking the devserver, it
makes a little sense that we know what it is doing under the sheets.  The code
that would have created those links is very convoluted in devserver as it is
now, and I'm wary of creating unintended side effects by changing it.

[anush, 2010-06-09 20:46:50]

Please be aware that the scripts are now in crosutils.git

Since it is a new script please add the prefix cros_ to it and put it in the
crosutils.git:bin/ dir.  There is one more cl which will attempt to create this
bin/ dir but if you get there first you can create the bin/ dir.

[Paul Stewart, 2010-06-09 21:32:03]

Okay.  It's moved.

[Sam Leffler, 2010-06-09 23:18:44]

LGTM (based on private conversations as codereview is messed up due to git repo
move)

[pstew1, 2010-06-11 18:50:17]

So, will there be any more scripts joining mine in bin/?  Right now my
script doesn't actually work correctly because it assumes the other
scripts should be in the same directory.  This appears to be common
practice, but right now it is feeling lonely. :-)

--
Paul

On Wed, Jun 9, 2010 at 1:46 PM,  <anush@chromium.org> wrote:
> Please be aware that the scripts are now in crosutils.git
>
> Since it is a new script please add the prefix cros_ to it and put it in the
> crosutils.git:bin/ dir.  There is one more cl which will attempt to create
> this
> bin/ dir but if you get there first you can create the bin/ dir.
>
> http://codereview.chromium.org/2724009/show
>