Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 2724001: Removes the spellchecker dictionaries from the source tarball.... (Closed)

Created:
10 years, 6 months ago by Hironori Bono
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Removes the spellchecker dictionaries from the source tarball. The spellchecker dictionaries, which are used only for unit tests, consumes lots of space in the source tarball. To reduce the sizeo of a source tarball, this change removes them from the source tarball. BUG=none TEST=See the source tarball does not include "src/third_party/hunspell_dictionaries/*". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/export_tarball/export_tarball.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Hironori Bono
10 years, 6 months ago (2010-06-08 01:03:27 UTC) #1
Nicolas Sylvain
10 years, 6 months ago (2010-06-09 14:12:11 UTC) #2
LGTM

On Mon, Jun 7, 2010 at 6:03 PM, <hbono@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Removes the spellchecker dictionaries from the source tarball.
> The spellchecker dictionaries, which are used only for unit tests, consumes
> lots
> of space in the source tarball. To reduce the sizeo of a source tarball,
> this
> change removes them from the source tarball.
>
> BUG=none
> TEST=See the source tarball does not include
> "src/third_party/hunspell_dictionaries/*".
>
> Please review this at http://codereview.chromium.org/2724001/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     tools/export_tarball/export_tarball.py
>
>
> Index: tools/export_tarball/export_tarball.py
> ===================================================================
> --- tools/export_tarball/export_tarball.py      (revision 49110)
> +++ tools/export_tarball/export_tarball.py      (working copy)
> @@ -32,6 +32,7 @@
>     'src/chrome/test/data',
>     'o3d/documentation',
>     'o3d/samples',
> +    'third_party/hunspell_dictionaries',
>     'third_party/lighttpd',
>     'third_party/vc_80',
>     'third_party/WebKit/LayoutTests',
>
>
>

Powered by Google App Engine
This is Rietveld 408576698