Issue 27239: [chromium-reviews] Rebaseline SVG layout test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27239: [chromium-reviews] Rebaseline SVG layout test (Closed)

Created:
11 years, 10 months ago by sidchat (Google)

Modified:
9 years, 7 months ago

Reviewers:
Finnur

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Rebaseline an SVG layout test. The border lines of the top box are drawn in a slightly different shade of red compared to the baseline, and as always, the vertical edge lines of the entire image is in a very slight different shade. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10549

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -6 lines)			Patch
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png	View	Binary file		0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	webkit/tools/layout_tests/test_lists/tests_fixable.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sidchat (Google)

This one has a visibly different shade of red when the top box is drawn ...

11 years, 10 months ago (2009-02-26 22:11:31 UTC) #1

Finnur

11 years, 10 months ago (2009-02-26 23:22:08 UTC) #2

I'm not an expert on this, but this looks reasonable to me... :)

Expand Messages | Collapse Messages