Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 27236: Enforce new id format (hex str of sha-1) (Closed)

Created:
11 years, 10 months ago by Erik does not do reviews
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enforce new id format (hex str of sha-1) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10529

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -27 lines) Patch
M chrome/browser/extensions/extension.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M chrome/browser/extensions/extensions_service_unittest.cc View 5 chunks +20 lines, -10 lines 0 comments Download
M chrome/test/data/extensions/bad/missing_content_script/1/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/good.crx View Binary file 0 comments Download
M chrome/test/data/extensions/good/extension1/1/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/good/extension2/2/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/good/extension3/1.0/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik does not do reviews
11 years, 10 months ago (2009-02-26 21:30:26 UTC) #1
Aaron Boodman
11 years, 10 months ago (2009-02-26 21:59:20 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698