Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 27234: DelayTimer destruction test (Closed)

Created:
11 years, 10 months ago by agl
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a test to DelayTimer ensure that the callback is never made once the DelayTimer has been destroyed.

Patch Set 1 #

Patch Set 2 : ... #

Patch Set 3 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M base/timer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M base/timer_unittest.cc View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
agl
darin: review jam: cc
11 years, 10 months ago (2009-02-26 21:05:40 UTC) #1
darin (slow to review)
I'm confused... the destructor of OneShotTimer<T> does the same thing, and timer_ is a member ...
11 years, 10 months ago (2009-02-26 21:28:32 UTC) #2
agl
On 2009/02/26 21:28:32, darin wrote: > I'm confused... the destructor of OneShotTimer<T> does the same ...
11 years, 10 months ago (2009-02-26 21:35:23 UTC) #3
agl
Comment added to DelayTimer
11 years, 10 months ago (2009-02-26 21:47:11 UTC) #4
darin (slow to review)
11 years, 10 months ago (2009-02-26 22:08:14 UTC) #5 
LGTM

Powered by Google App Engine
This is Rietveld 408576698