Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Side by Side Diff: base/file_version_info_linux.cc

Issue 27232: Convert FileVersionInfo NOTIMPLEMENTED()s into a bug. (Closed)
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_version_info.h" 5 #include "base/file_version_info.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 10
11 // TODO(port): Replace stubs with real implementations. We need a non-NULL 11 // TODO(port): This whole file is stubbed. We can't return NULL
12 // FileVersionInfo object that reads info about the current binary. This is 12 // because that is used as a catastrophic error code where the file
13 // relatively easy to do under Windows, as there's some win32 API functions 13 // doesn't exist or can't be opened.
14 // that return that information and Microsoft encourages developers to fill out
15 // that standard information block.
16 // 14 //
17 // We can't return NULL because that is used as a catastrophic error code where 15 // See http://code.google.com/p/chromium/issues/detail?id=8132 for a discussion
18 // the file doesn't exist or can't be opened. 16 // on what we should do with this module.
19 17
20 FileVersionInfo::FileVersionInfo() {} 18 FileVersionInfo::FileVersionInfo() {}
21 19
22 FileVersionInfo::~FileVersionInfo() {} 20 FileVersionInfo::~FileVersionInfo() {}
23 21
24 // static 22 // static
25 FileVersionInfo* FileVersionInfo::CreateFileVersionInfoForCurrentModule() { 23 FileVersionInfo* FileVersionInfo::CreateFileVersionInfoForCurrentModule() {
26 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
27 return new FileVersionInfo(); 24 return new FileVersionInfo();
28 } 25 }
29 26
30 std::wstring FileVersionInfo::company_name() { 27 std::wstring FileVersionInfo::company_name() {
31 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
32 return L""; 28 return L"";
33 } 29 }
34 30
35 std::wstring FileVersionInfo::company_short_name() { 31 std::wstring FileVersionInfo::company_short_name() {
36 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
37 return L""; 32 return L"";
38 } 33 }
39 34
40 std::wstring FileVersionInfo::product_name() { 35 std::wstring FileVersionInfo::product_name() {
41 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
42 return L""; 36 return L"";
43 } 37 }
44 38
45 std::wstring FileVersionInfo::product_short_name() { 39 std::wstring FileVersionInfo::product_short_name() {
46 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
47 return L""; 40 return L"";
48 } 41 }
49 42
50 std::wstring FileVersionInfo::internal_name() { 43 std::wstring FileVersionInfo::internal_name() {
51 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
52 return L""; 44 return L"";
53 } 45 }
54 46
55 std::wstring FileVersionInfo::product_version() { 47 std::wstring FileVersionInfo::product_version() {
56 // When un-stubbing, implementation in file_version_info.cc should be ok.
57 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
58 return L"0.1.2.3.4.5.6-lie"; 48 return L"0.1.2.3.4.5.6-lie";
59 } 49 }
60 50
61 std::wstring FileVersionInfo::private_build() { 51 std::wstring FileVersionInfo::private_build() {
62 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
63 return L""; 52 return L"";
64 } 53 }
65 54
66 std::wstring FileVersionInfo::special_build() { 55 std::wstring FileVersionInfo::special_build() {
67 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
68 return L""; 56 return L"";
69 } 57 }
70 58
71 std::wstring FileVersionInfo::comments() { 59 std::wstring FileVersionInfo::comments() {
72 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
73 return L""; 60 return L"";
74 } 61 }
75 62
76 std::wstring FileVersionInfo::original_filename() { 63 std::wstring FileVersionInfo::original_filename() {
77 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
78 return L""; 64 return L"";
79 } 65 }
80 66
81 std::wstring FileVersionInfo::file_description() { 67 std::wstring FileVersionInfo::file_description() {
82 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
83 return L""; 68 return L"";
84 } 69 }
85 70
86 std::wstring FileVersionInfo::file_version() { 71 std::wstring FileVersionInfo::file_version() {
87 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
88 return L"0.1.2.3.4.5.6-lie"; 72 return L"0.1.2.3.4.5.6-lie";
89 } 73 }
90 74
91 std::wstring FileVersionInfo::legal_copyright() { 75 std::wstring FileVersionInfo::legal_copyright() {
92 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
93 return L""; 76 return L"";
94 } 77 }
95 78
96 std::wstring FileVersionInfo::legal_trademarks() { 79 std::wstring FileVersionInfo::legal_trademarks() {
97 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
98 return L""; 80 return L"";
99 } 81 }
100 82
101 std::wstring FileVersionInfo::last_change() { 83 std::wstring FileVersionInfo::last_change() {
102 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
103 return L"Last Thursday"; 84 return L"Last Thursday";
104 } 85 }
105 86
106 bool FileVersionInfo::is_official_build() { 87 bool FileVersionInfo::is_official_build() {
107 NOTIMPLEMENTED() << "The current FileVersionInfo is a lie.";
108 return false; 88 return false;
109 } 89 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698