Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 27228: Fix BrowserTest.ThirtyFourTabs and possibly other ui tests in single-process ... (Closed)

Created:
11 years, 10 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
kuchhal, Matt Perry
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix BrowserTest.ThirtyFourTabs and possibly other ui tests in single-process mode. The problem was that RenderProcess was being destructed on both threads at the same time because of the scoped_ptr. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10507

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/browser/browser_uitest.cc View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
11 years, 10 months ago (2009-02-26 20:28:05 UTC) #1
Matt Perry
LGTM http://codereview.chromium.org/27228/diff/1/2 File chrome/browser/renderer_host/browser_render_process_host.cc (right): http://codereview.chromium.org/27228/diff/1/2#newcode74 Line 74: class RendererMainThread : public base::Thread { please ...
11 years, 10 months ago (2009-02-26 20:34:30 UTC) #2
jam
http://codereview.chromium.org/27228/diff/1/2 File chrome/browser/renderer_host/browser_render_process_host.cc (right): http://codereview.chromium.org/27228/diff/1/2#newcode74 Line 74: class RendererMainThread : public base::Thread { On 2009/02/26 ...
11 years, 10 months ago (2009-02-26 20:36:00 UTC) #3
kuchhal
11 years, 10 months ago (2009-02-26 21:02:45 UTC) #4
http://codereview.chromium.org/27228/diff/1003/6
File chrome/browser/browser_uitest.cc (right):

http://codereview.chromium.org/27228/diff/1003/6#newcode93
Line 93: TEST_F(BrowserTest, ThirtyFourTabs) {
You can remove the comment above this line too.

Powered by Google App Engine
This is Rietveld 408576698