Linux: support displays without Xrender support.

Linux: support displays without Xrender support.

VNC servers don't support Xrender. For this use case, we implement a
slow fallback which byte-fiddles the Skia bitmaps as needed to support
32 and 24 bit visuals.

[Evan Martin, 2009-02-26 20:41:56]

lg, minor comments

http://codereview.chromium.org/27227/diff/1/2
File chrome/browser/renderer_host/backing_store.h (right):

http://codereview.chromium.org/27227/diff/1/2#newcode116
Line 116: // given depth.
"given" here refers to the depth below?

http://codereview.chromium.org/27227/diff/1/3
File chrome/browser/renderer_host/backing_store_x.cc (right):

http://codereview.chromium.org/27227/diff/1/3#newcode114
Line 114: const uint32_t* bitmap_in = static_cast<const
uint32_t*>(bitmap->memory());
  COMPILE_ASSERT(__BYTE_ORDER == __LITTLE_ENDIAN,
                 assumes_little_endian);

here or somewhere around here, just so it's not so hard for someone else to find
this code when we do our MIPS port.  :P

http://codereview.chromium.org/27227/diff/1/3#newcode136
Line 136: CHECK(false) << "Sorry, we don't support your visual depth without "
maybe include the visual depth in the error message?

http://codereview.chromium.org/27227/diff/1/5
File chrome/common/x11_util.cc (right):

http://codereview.chromium.org/27227/diff/1/5#newcode93
Line 93: // have been in every version.
this comment doesn't parse.  i think you left out some wordsd.

http://codereview.chromium.org/27227/diff/1/5#newcode115
Line 115: XPixmapFormatValues* formats = XListPixmapFormats(dpy, &count);
Wonder if this is a sync call...

[agl, 2009-02-26 20:51:44]

http://codereview.chromium.org/27227/diff/1/2
File chrome/browser/renderer_host/backing_store.h (right):

http://codereview.chromium.org/27227/diff/1/2#newcode116
Line 116: // given depth.
On 2009/02/26 20:41:56, Evan Martin wrote:
> "given" here refers to the depth below?

Yes, comment updated.

http://codereview.chromium.org/27227/diff/1/3
File chrome/browser/renderer_host/backing_store_x.cc (right):

http://codereview.chromium.org/27227/diff/1/3#newcode114
Line 114: const uint32_t* bitmap_in = static_cast<const
uint32_t*>(bitmap->memory());
On 2009/02/26 20:41:56, Evan Martin wrote:
>   COMPILE_ASSERT(__BYTE_ORDER == __LITTLE_ENDIAN,
>                  assumes_little_endian);
> 
> here or somewhere around here, just so it's not so hard for someone else to
find
> this code when we do our MIPS port.  :P

Done.

http://codereview.chromium.org/27227/diff/1/3#newcode136
Line 136: CHECK(false) << "Sorry, we don't support your visual depth without "
On 2009/02/26 20:41:56, Evan Martin wrote:
> maybe include the visual depth in the error message?

Done.

http://codereview.chromium.org/27227/diff/1/5
File chrome/common/x11_util.cc (right):

http://codereview.chromium.org/27227/diff/1/5#newcode93
Line 93: // have been in every version.
On 2009/02/26 20:41:56, Evan Martin wrote:
> this comment doesn't parse.  i think you left out some wordsd.

Done.

http://codereview.chromium.org/27227/diff/1/5#newcode115
Line 115: XPixmapFormatValues* formats = XListPixmapFormats(dpy, &count);
On 2009/02/26 20:41:56, Evan Martin wrote:
> Wonder if this is a sync call...

Should be cached in Xlib.