Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 27222: Chrome side to implement WebMimeRegistry. (Closed)

Created:
11 years, 10 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai, dglazkov
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Chrome side to implement WebMimeRegistry. R=dglazkov Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10532

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -250 lines) Patch
M chrome/chrome.xcodeproj/project.pbxproj View 6 chunks +7 lines, -1 line 0 comments Download
M chrome/renderer/render_thread.h View 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 3 4 5 6 3 chunks +28 lines, -31 lines 0 comments Download
M chrome/renderer/renderer.scons View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/renderer.vcproj View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_glue.cc View 1 2 3 4 5 2 chunks +0 lines, -41 lines 0 comments Download
A chrome/renderer/renderer_webkitclient_impl.h View 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/renderer/renderer_webkitclient_impl.cc View 1 chunk +57 lines, -0 lines 0 comments Download
M webkit/glue/SConscript View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/chromium_bridge_impl.cc View 1 2 chunks +0 lines, -51 lines 0 comments Download
M webkit/glue/glue.vcproj View 2 chunks +16 lines, -8 lines 0 comments Download
M webkit/glue/glue_util.h View 2 chunks +7 lines, -0 lines 0 comments Download
M webkit/glue/glue_util.cc View 1 2 3 4 5 2 chunks +18 lines, -1 line 0 comments Download
M webkit/glue/plugins/plugin_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A webkit/glue/simple_webmimeregistry_impl.h View 1 chunk +26 lines, -0 lines 0 comments Download
A webkit/glue/simple_webmimeregistry_impl.cc View 1 2 3 4 5 1 chunk +61 lines, -0 lines 0 comments Download
D webkit/glue/webkit_client_impl.h View 1 chunk +0 lines, -26 lines 0 comments Download
D webkit/glue/webkit_client_impl.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M webkit/glue/webkit_glue.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -15 lines 0 comments Download
A + webkit/glue/webkitclient_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
A + webkit/glue/webkitclient_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/mac/TestShell.xcodeproj/project.pbxproj View 5 chunks +15 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/run_all_tests.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 2 3 4 1 chunk +0 lines, -15 lines 0 comments Download
M webkit/tools/test_shell/test_shell.vcproj View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 3 chunks +4 lines, -8 lines 0 comments Download
A webkit/tools/test_shell/test_shell_webkit_init.h View 1 chunk +35 lines, -0 lines 0 comments Download
M webkit/webkit.gyp View 3 chunks +5 lines, -2 lines 1 comment Download
M webkit/webkit.xcodeproj/project.pbxproj View 9 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
darin (slow to review)
11 years, 10 months ago (2009-02-26 19:44:20 UTC) #1
darin (slow to review)
11 years, 10 months ago (2009-02-26 19:44:43 UTC) #2
dglazkov
LGTM!
11 years, 10 months ago (2009-02-26 23:02:39 UTC) #3
Mark Mentovai
http://codereview.chromium.org/27222/diff/1183/1209 File webkit/webkit.gyp (right): http://codereview.chromium.org/27222/diff/1183/1209#newcode4042 Line 4042: '../third_party/WebKit/WebKit/chromium/public/WebMimeRegistry.h', Thank you!
11 years, 10 months ago (2009-02-27 01:44:43 UTC) #4
Mark Mentovai
11 years, 10 months ago (2009-02-27 15:35:13 UTC) #5 
This may have caused Linux dbg test_shell_tests to fail

http://build.chromium.org/buildbot/waterfall/builders/Modules%20Linux%20(dbg)...

but I'm not positive because the compile failed for that cycle and a few after,
so the window's unfortunately a few builds wide.

Powered by Google App Engine
This is Rietveld 408576698