Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 27219: Fixing crash in StartFinding (2nd attempt).... (Closed)

Created:
11 years, 10 months ago by Finnur
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixing crash in StartFinding (2nd attempt). The first attempt to fix this was unsuccessful and crashes showed up again during the automated ui testing. I still can't reproduce locally, but when I look again at the crash dump I think that the fact that it looked like the FindBarView was destroyed is misleading and the real issue is the same as with the crash in StopFinding (that web_contents has been destroyed moments before we receive the request). I am therefore removing the code I added earlier and replacing it with a null check for web_contents. TEST=Covered by automated ui tests. BUG=8048 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/views/find_bar_view.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Finnur
11 years, 10 months ago (2009-02-26 18:37:27 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698