Issue 27213: Two small changes regarding GC ticks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27213: Two small changes regarding GC ticks. (Closed)

Created:
11 years, 10 months ago by Mikhail Naganov

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Two small changes regarding GC ticks. 1) Don't try to sample the stack if VM is in 'GC' state 2) Show GC ticks in profiler statistics Committed: http://code.google.com/p/v8/source/detail?r=1380

Patch Set 1 #

Total comments: 2

Patch Set 2 : Displaying GC ticks as a section #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -11 lines)			Patch
	M	src/log.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	tools/tickprocessor.py	View	1	7 chunks	+21 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/27213/diff/1/3 File tools/tickprocessor.py (right): http://codereview.chromium.org/27213/diff/1/3#newcode334 Line 334: }) How about putting a 'GC' section ...

11 years, 10 months ago (2009-02-26 15:35:45 UTC) #2

Mikhail Naganov

11 years, 10 months ago (2009-02-26 15:45:40 UTC) #3

http://codereview.chromium.org/27213/diff/1/3
File tools/tickprocessor.py (right):

http://codereview.chromium.org/27213/diff/1/3#newcode334
Line 334: })
On 2009/02/26 15:35:46, Søren Gjesse wrote:
> How about putting a 'GC' section here like the 'Unknown' section?
> 
> 

Done.

Expand Messages | Collapse Messages