Issue 2721007: Fix ProcessSingletonWinTest using default profile....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2721007: Fix ProcessSingletonWinTest using default profile.... (Closed)

Created:
10 years, 6 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
MAD, robertshield, cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, John Grabowski, ben+cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix ProcessSingletonWinTest using default profile. Rename to ProcessSingletonTest. Fix issues preventing the test from working on Linux, and enable it there. Test both normal start up and first-run startup paths(win-only). BUG=38572 TEST=run the test (both with and without an existing profile in the default place) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50022

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -298 lines)			Patch
M	base/process_util_posix.cc	View	2 chunks	+10 lines, -1 line	0 comments	Download
A +	chrome/browser/process_singleton_uitest.cc	View	10 chunks	+52 lines, -25 lines	0 comments	Download
D	chrome/browser/process_singleton_win_uitest.cc	View	1 chunk	+0 lines, -270 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	3 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

MAD

10 years, 6 months ago (2010-06-16 03:56:16 UTC) #3

LGTM...

Thanks for fixing this!

Really sorry about the delay, this slipped through the cracks somehow...

BYE
MAD

Expand Messages | Collapse Messages