Issue 2721005: Mark HostCache as NonThreadSafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2721005: Mark HostCache as NonThreadSafe. (Closed)

Created:
10 years, 6 months ago by cbentzel

Modified:
9 years, 7 months ago

Reviewers:
eroman, willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

Mark HostCache as NonThreadSafe. BUG=None TEST=net_unittests, and ran chrome with net_internals DNS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49285

Patch Set 1 #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -26 lines)			Patch
	M	net/base/host_cache.h	View		4 chunks	+15 lines, -26 lines	2 comments	Download
	M	net/base/host_cache.cc	View		3 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

LGTM2 http://codereview.chromium.org/2721005/diff/1/3 File net/base/host_cache.h (right): http://codereview.chromium.org/2721005/diff/1/3#newcode114 net/base/host_cache.h:114: FRIEND_TEST(HostCacheTest, NoCache); Was this \n deletion intentional? Up ...

10 years, 6 months ago (2010-06-08 20:24:21 UTC) #3

cbentzel

10 years, 6 months ago (2010-06-09 18:01:27 UTC) #4

http://codereview.chromium.org/2721005/diff/1/3
File net/base/host_cache.h (right):

http://codereview.chromium.org/2721005/diff/1/3#newcode114
net/base/host_cache.h:114: FRIEND_TEST(HostCacheTest, NoCache);
On 2010/06/08 20:24:22, willchan wrote:
> Was this \n deletion intentional?  Up to you, but it seemed to make sense to
me
> to have it.

Unintentional, thanks for the catch.

Expand Messages | Collapse Messages