Issue 27207: net links v8, but didn't have a dep on it, so clean builds failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27207: net links v8, but didn't have a dep on it, so clean builds failed. (Closed)

Created:
11 years, 10 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Amanda Walker

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

net links v8, but didn't have a dep on it, so clean builds failed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10461

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	net/net.xcodeproj/project.pbxproj	View		3 chunks	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

TVL

Actually, should the link only be needed when someone links net? (they would also have ...

11 years, 10 months ago (2009-02-26 14:29:20 UTC) #3

TVL

11 years, 10 months ago (2009-02-26 14:30:41 UTC) #4

On 2009/02/26 14:29:20, TVL wrote:
> Actually, should the link only be needed when someone links net?  (they would
> also have to link v8, but libnet shouldn't have to link v8 in a static lib
> world, the unittest might need it)

landing w/ awalkers LG to get the bots happy, mark - my question still stand for
folling cleanup.

Expand Messages | Collapse Messages