Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 27202: Change the D8 JavaScript debugger to fully use the JSON protocol.... (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Change the D8 JavaScript debugger to fully use the JSON protocol. The D8 debugger frontend now only processes JSON messages. Before the debugger events was passed as objects. Changed the debugger events JSON generation to use the same serailizer as the responses to requests. This provides correct serialization of mirror objects in debugger events. Renamed ResponsePacket to ProtocolMessage as it is not only used for responses. Committed: http://code.google.com/p/v8/source/detail?r=1374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -84 lines) Patch
M src/d8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.js View 4 chunks +57 lines, -53 lines 0 comments Download
M src/d8-debug.cc View 1 chunk +12 lines, -1 line 0 comments Download
M src/debug-delay.js View 6 chunks +64 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-26 11:17:38 UTC) #1
Mads Ager (chromium)
11 years, 10 months ago (2009-02-26 11:22:01 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698